Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hook for Hydra config system (hydra-core) #470

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Add hook for Hydra config system (hydra-core) #470

merged 1 commit into from
Jul 24, 2022
+54 −1

Conversation

rokm
Copy link
Member

@rokm rokm commented Jul 24, 2022

Closes #424.

@rokm rokm merged commit 9e840e3 into pyinstaller:master Jul 24, 2022
@rokm rokm deleted the hook-hydra branch July 24, 2022 21:16
@matinmoezzi
Copy link

matinmoezzi commented Jul 11, 2024 •
edited
Loading

Hi,
python 3.8.19
hydra-core version = 1.3.2
pyinstaller version = 6.9.0
It seems that hydra-plugins issue is not still solved.

Traceback (most recent call last):
  File "main.py", line 97, in <module>
    app()
  File "hydra/main.py", line 94, in decorated_main
  File "hydra/_internal/utils.py", line 337, in _run_hydra
  File "hydra/_internal/utils.py", line 190, in create_automatic_config_search_path
  File "hydra/_internal/utils.py", line 203, in create_config_search_path
  File "hydra/core/plugins.py", line 46, in instance
  File "hydra/core/singleton.py", line 17, in instance
  File "hydra/core/singleton.py", line 13, in __call__
  File "hydra/core/plugins.py", line 54, in __init__
  File "hydra/core/plugins.py", line 71, in _initialize
  File "hydra/core/plugins.py", line 186, in _scan_all_plugins
AttributeError: 'PyiFrozenImporter' object has no attribute 'find_module'
[45564] Failed to execute script 'main' due to unhandled exception!

However, it's working with --noarchive flag. With no archive, hydra directory contains all plugins in .pyc.

@rokm
Copy link
Member Author

rokm commented Jul 11, 2024

It seems that hydra-plugins issue is not still solved.

See facebookresearch/hydra#2531. We have no plans of reverting pyinstaller/pyinstaller#7344.

@rokm
Copy link
Member Author

rokm commented Jul 11, 2024

Although on the other hand, we can also work around this on our side by collecting those plugins as source .py files only, if we detect python < 3.10 and PyInstaller >= 5.8: #760.

@matinmoezzi
Copy link

@rokm Thank you so much. I upgraded python=3.8 to 3.10 and it solved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoodsend bwoodsend bwoodsend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Hydra config system
3 participants
@rokm @matinmoezzi @bwoodsend